Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors Sub's
servo
functions. they are now called actuators.This now allows them to be placed on any outputs, rather than the hard-coded servo9, 10, and 11.
This also exposes parameters for setting both the initial increment step and an acceleration factor.
The main goal was to introduce the user-adjustable increment and acceleration, but as things were a mess, I felt I had to try to make it better.
The "Actuator" choice was so that we could easily plug handling of MAV_CMD_DO_SET_ACTUATOR in on a following PR.
I'm considering setting the default servo9-11 functions to the corresponding actuators in order for this to be no change to users upgrading.
I swear we do want to stop relying on these hardcoded button settings, but some things are easier to migrate away than others 🥲