-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AP_HAL_ChibiOS: Added support for ZeroOne_Air flight controller #29022
AP_HAL_ChibiOS: Added support for ZeroOne_Air flight controller #29022
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Commit list needs cleaning up before merge. |
We've changed the content, please help us review it again, thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pinout diagram has many errors:
- no debug port shown or labelled
- TELEM1: TX1 should be TX7, etc.
- GPS2/I2C: should be TX8/RX8
- GPS1/Safety: should be TX1/RX1
- UART4: should be TX4/RX6
- should label the boot button
| SERIAL3 | GPS1 | USART1 |DMA Enabled | | ||
| SERIAL4 | GPS2 | UART8 |DMA Enabled | | ||
| SERIAL5 | Telem3 | USART2 |DMA Enabled | | ||
| SERIAL6 | UART4 | UART4 |DMA Enabled | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| SERIAL6 | UART4 | UART4 |DMA Enabled | | |
| SERIAL6 | User | UART4 |DMA Enabled | | |
| SERIAL7 | Debug | UART3 |DMA Enabled | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: debug port is not shown on ports image....where is it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still have question on where debug port is located
Hello, the content has been modified according to your requirements, please confirm again. |
aside from the debug port location question...looks good...needs squashing, see https://youtu.be/iMUWQUD_Rsg |
I've tried to squashing using the method in your video, but I haven't used it before, so it's not very successful, can I merge it in the form of a new PR |
I can do it for you this weekend...what about my debug port question? |
34eb4b7
to
e850491
Compare
the problem is you kept merging master into this branch.....in the future don't do that....you can update your local master branch to the ArduPilot upstream, and then do a git rebase master on the PR branch if you want it rebased on things that have been added to the master...but don't merge them....I had to remove ~20 master branch commits interspersed between your commits...then do a squash and library split....it good now |
AP_HAL_ChibiOS: Added support for our new ZeroOne_Air flight controller