AP_Mount: zoom for Viewpro IR sensor #29140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmackay9
reviewed
Jan 27, 2025
rmackay9
reviewed
Jan 27, 2025
rmackay9
reviewed
Jan 27, 2025
|
Hi @eppravitra, Thanks for this, it looks pretty good to me with the exception of a few white space issues. I guess you've tested this on real hardware? Normally we like to hear what testing has been done because it gives us more confidence that it's ready to be merged |
eppravitra
force-pushed
the
viewpro-irzoom
branch
from
b2ce4fe to
e0a095b
Compare
|
Hi @rmackay9 , All the changes you requested have been included. I flashed the most recent change into CubeOrangePlus. The Cube is connected to ViewPro A10T via UART. |
|
as discussed on the EU dev call I'll test this on my camera and then if it works I'll merge it |
|
tested and works great, thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add zoom function for ViewPro IR sensor. Also read IR zoom value from Viewpro