Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable addonlists_show_addon_version_number.css by default for FF60 #121

Closed
wants to merge 1 commit into from
Closed

Conversation

stonecrusher
Copy link
Contributor

Disable addonlists_show_addon_version_number.css by default as it doesn't work anymore in FF60 and prevents the addonlist to be displayed

Disable `addonlists_show_addon_version_number.css` by default as it doesn't work anymore in FF60 and prevents the addonlist to be displayed
@stonecrusher
Copy link
Contributor Author

stonecrusher commented May 10, 2018

Maybe you also disable location bars classic autocomplete popup from #43
I don't use it and couldn't find it. Don't know if it has negative impact if it stays activated in FF60.

@Aris-t2
Copy link
Owner

Aris-t2 commented May 10, 2018

The version number in add-on lists works fine up to Firefox 62 for me.
Are you using the latest files from this project?

1

I excluded the two lined autocomplete popup option from default enabled settings a while ago, because it was incompatible to popups search features. It still works fine, if you ignore the search stuff.

Please run tests with projects latest files on a clean browser profile before assuming they don't work. No need for an immediate commit. ;-)

@stonecrusher
Copy link
Contributor Author

Sorry, I'll retest again.
Everytime I enable addonlists_show_addon_version_number.css I got an empty "list". Maybe something went wrong with my update.

And I just made the PR for you to have an easy one-click solution. Accept or deny :-)
I'm not angry for denial if there is a hint why.

@Aris-t2
Copy link
Owner

Aris-t2 commented May 10, 2018

Can you confirm that you are using the latest files?

@stonecrusher
Copy link
Contributor Author

Latest, yes.
But after some debugging I've found out xml folder wasn't recopied properly (folder was there but files not copied because of different fileextension).
My fault.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants