This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
fix: splashscreen fullscreen & ui tweaks #1691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbarnsley
requested review from
faustbrian,
ItsANameToo and
luciorubeens
as code owners
ghost
added
Complexity: Low
Codecov Report
@@ Coverage Diff @@
## develop #1691 +/- ##
========================================
Coverage 63.87% 63.87%
========================================
Files 139 139
Lines 3815 3815
Branches 797 797
========================================
Hits 2437 2437
Misses 1152 1152
Partials 226 226Continue to review full report at Codecov.
|
ItsANameToo
reviewed
Feb 20, 2020
| if (process.platform !== 'darwin') { | ||
| app.quit() | ||
| } | ||
| app.quit() |
There was a problem hiding this comment.
🤔 might want to discuss this to be sure if this is what we want to have happen on mac
There was a problem hiding this comment.
Me and Sam discussed it :colbert: it fixes a bug, plugins can't be installed after: closing all windows (not quitting the app) then opening the window again and trying to install a plugin
There was a problem hiding this comment.
Has anyone looked into that yet? :hmhm:
ItsANameToo
approved these changes
Feb 20, 2020
ghost
deleted the
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist