Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Add yellow color to Find issues button in light mode and default in dark mode #213 #223

Merged
merged 3 commits into from
Jun 7, 2023

Conversation

ThGnommy
Copy link
Contributor

@ThGnommy ThGnommy commented Jun 6, 2023

I added a new value to the main theme context.

Light Theme:

bg_DefaultBtn: "bg-yellow-400 hover:bg-yellow-500",

Dark Theme:

bg_DefaultBtn: "bg-purple-500 hover:bg-purple-600",

Then I applied it to the button in Home.js

I thought that this can be a default button we can reuse as needed.
But I'm not secure about it.

What do you think?

@welcome
Copy link

welcome bot commented Jun 6, 2023

💖Thanks for opening this pull request! Please check out our contributing guidelines.💖

@vercel
Copy link

vercel bot commented Jun 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
starter-hive ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2023 3:31pm

Copy link
Owner

@ArslanYM ArslanYM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@ArslanYM ArslanYM merged commit ce40706 into ArslanYM:main Jun 7, 2023
@welcome
Copy link

welcome bot commented Jun 7, 2023

Congrats on merging your first pull request! We here at StarterHive are proud of you!🎉🎉🎉
alt text

@ArslanYM
Copy link
Owner

ArslanYM commented Jun 7, 2023

@ThGnommy Thankyou for your contribution. I was thinking about creating a better looking light mode for the web app. Since the images in the main page are based on dark mode , with purple accent. I would love to hear more from you about this. If youre in for this issue, Raise a discussion so we can start working on the light mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants