Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): enhance config file and data dir retrieval #992

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

qwqcode
Copy link
Member

@qwqcode qwqcode commented Oct 2, 2024

  • Add xdg package for XDG base directory support
  • Update RetrieveConfigFile to search in XDG_CONFIG_HOME and /etc
  • Add RetrieveDataDir to find data directory in XDG_DATA_HOME and /var/lib
  • Improve comments for better understanding of search order

The preparatory work for PR: #991

- Add xdg package for XDG base directory support
- Update RetrieveConfigFile to search in XDG_CONFIG_HOME and /etc
- Add RetrieveDataDir to find data directory in XDG_DATA_HOME and /var/lib
- Improve comments for better understanding of search order
@qwqcode qwqcode marked this pull request as ready for review October 2, 2024 17:56
@qwqcode qwqcode requested a review from kilesduli October 2, 2024 17:57
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 51.28205% with 19 lines in your changes missing coverage. Please review.

Project coverage is 32.24%. Comparing base (34d7936) to head (391ebb6).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
cmd/base.go 0.00% 18 Missing ⚠️
internal/config/base.go 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #992      +/-   ##
==========================================
+ Coverage   32.09%   32.24%   +0.14%     
==========================================
  Files         206      206              
  Lines        6857     6888      +31     
==========================================
+ Hits         2201     2221      +20     
- Misses       4502     4513      +11     
  Partials      154      154              
Flag Coverage Δ
go 32.24% <51.28%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qwqcode qwqcode merged commit 1d5811a into master Oct 3, 2024
7 checks passed
@qwqcode qwqcode deleted the feat/config branch October 3, 2024 07:04
@kilesduli kilesduli removed their request for review October 3, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant