Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-110 | Sync arrow position with Digital Crown orientation #111

Merged
merged 2 commits into from
Jun 16, 2023

Conversation

bashjs
Copy link
Contributor

@bashjs bashjs commented Jun 13, 2023

Issue: #110

Changes

  • Used WKInterfaceDevice.current().crownOrientation to read the position of the Digital Crown
  • Changed the help arrow from pointing to the right (or left) to pointing down to avoid confusion when placed next to the Cancel button
  • Minor View cleanup

Notes

  • These are my first lines of code in Swift
  • Xcode Simulator has no toggle to simulate Digital Crown orientation
crownOrientation == .left crownOrientation == .right
Screenshot 2023-06-13 at 23 45 01 Screenshot 2023-06-13 at 23 43 46

@Jon-b-m
Copy link
Member

Jon-b-m commented Jun 15, 2023

Thanks! Did you test this update also on different Watch sizes? The format, like for instance your spaces value, sometimes need special tweaking depending on Watch size.

@bashjs
Copy link
Contributor Author

bashjs commented Jun 15, 2023

Thanks! Did you test this update also on different Watch sizes? The format, like for instance your spaces value, sometimes need special tweaking depending on Watch size.

I tested it on my Ultra. I'll test in other watch simulators today.
What do you think about the shrunk "Cancel" button when the crown is on the left side? 🤔 I couldn't come up with a more elegant variant.

@Jon-b-m
Copy link
Member

Jon-b-m commented Jun 15, 2023

Thanks! Did you test this update also on different Watch sizes? The format, like for instance your spaces value, sometimes need special tweaking depending on Watch size.

What do you think about the shrunk "Cancel" button when the crown is on the left side? 🤔 I couldn't come up with a more elegant variant.

Removing the arrow or changing positions of the cancel button are two other alternatives...

@bashjs bashjs marked this pull request as draft June 15, 2023 19:50
@Jon-b-m Jon-b-m marked this pull request as ready for review June 16, 2023 09:04
@Jon-b-m Jon-b-m merged commit 88e8f10 into Artificial-Pancreas:dev Jun 16, 2023
@Jon-b-m
Copy link
Member

Jon-b-m commented Jun 16, 2023

I will merge it now. If we find issues, please be prepared fixing these later with new PRs!

Jon-b-m added a commit that referenced this pull request Jun 16, 2023
1. Refactored the new bolus calculator. Now just using one formula (using two was utterly confusing). Removed many of the restrictions and replaced those with warnings and alerts instead, making it possible to get a recommendation for a more normal bolus amount, even when for instance the BG is falling or the glucose predicted to temporarily dropping down below target glucose. The Eventual BG still needs to be over target for a recommendation. This limit is not removed. Added logging and error strings from oref0 to iAPS. Added localisations for oref0 strings and calculator.  Created a New bolus pop-up and new bolus alerts.

2, Add manual glucose. Add/Delete glucose (also to/from CoreData). For when between sensors or when sensor errors etc.

2. Add euglycemic range also to laying grouped glucose in laying TIR chart in stat view.

3  New Libre 2 versions. Support for patchInfo starting with "c5" (#104). Ported from the xdripswift repo

4.  Bug fix for adding insulin without blousing.

5. Changed xDrip name to xDrip4iOS in settings (#118), by @MikePlante1 

6. Configuration cgm to cgm configuration (#1) (#119), by @MikePlante1 

7.  ISSUE-110 | Sync arrow position with Digital Crown orientation (#111), by @bashjs 

8. New localizations and new Crowdin translations, thank you all Crowdin translators!

9. Other bug fixes.

10.  Version update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants