Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display translated messages on the toast #738

Merged
merged 5 commits into from
Apr 14, 2023
Merged

Conversation

impelcrypto
Copy link
Member

@impelcrypto impelcrypto commented Apr 12, 2023

Pull Request Summary

  • fix: display translated messages on the toast
  • feat: display subacan links on the toast after sending XCM transactions
  • todo: sending transactions via light client
    • Somehow we rollbacked useTokenTransfer.ts to old version after light client integration, so I've updated the file. Sending tokens via light client still doesn't work yet, but this is an another issue and we can fix it later.

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

This pull request makes the following changes:

Adds

  • feat: display subacan links after sending XCM transactions
    image

Fixes

fix: display translated messages on the toast

  • added translated successMessage as a parameter in service files in V2 structure

@github-actions
Copy link

github-actions bot commented Apr 12, 2023

Visit the preview URL for this PR (updated for commit 6931de6):

https://astar-apps--pr738-fix-usetokentransfer-84rh5nh0.web.app

(expires Thu, 20 Apr 2023 04:16:59 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

@impelcrypto impelcrypto marked this pull request as ready for review April 12, 2023 09:42
@impelcrypto
Copy link
Member Author

Hi @bobo-k2

Somehow we rollbacked useTokenTransfer.ts to old version after light client integration

I found that we rollbacked in this PR. Could you share with me what was the issue? So I can try to reproduce in this branch.
#679

@impelcrypto
Copy link
Member Author

CC: @Kahonnohak

@bobo-k2
Copy link
Contributor

bobo-k2 commented Apr 12, 2023

#679

Just paste the PR url in Slack, it will lead you to conversation about the issue.

@impelcrypto
Copy link
Member Author

impelcrypto commented Apr 12, 2023

@bobo-k2 I've fixed the issue mentioned at #679 at this commit

Copy link
Contributor

@bobo-k2 bobo-k2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@impelcrypto impelcrypto merged commit a98e6d7 into main Apr 14, 2023
@impelcrypto impelcrypto deleted the fix/useTokenTransfer branch April 14, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants