Improve WCU_RAW description #316
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oczoske
reviewed
Feb 6, 2025
There was a problem hiding this comment.
A bit too colloquial for my liking (maybe remove "and therefore are full of photons"). The relevant keyword should be INS.OPTI19.NAME (a value "CLOSED" seems plausible but afaik hasn't been defined yet). I have defined this keyword in the appendix in #309 so this can already be referenced here. INS.OPTI20.NAME (WCU focal plane mask) may also be of relevance but as long as the data from a template are not separated only a sanity check should be necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After discussion on Slack, it seems good to update this rather incorrect description of the WCU_OFF raws.