-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SpectralType class #42
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #42 +/- ##
==========================================
+ Coverage 99.16% 99.26% +0.09%
==========================================
Files 5 6 +1
Lines 361 409 +48
==========================================
+ Hits 358 406 +48
Misses 3 3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
O be a fine guy, kindly merge
Who needed that now??
Weeeell, technically one of our students would have benefited from this a little while back. More to the point, this will come in handy for scopesim-targets (maybe even for ScopeSim_Templates) and Pyckles and maybe also SpeXtra. Also, it took just this afternoon from initial idea to implementation including all 77 test cases, so why not 🤷♂️