Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create test to ensure names of efficiency extensions are identical to those of thetrace definitions #177

Open
hugobuddel opened this issue Apr 26, 2024 · 0 comments

Comments

@hugobuddel
Copy link
Collaborator

          > @teutoburg should we add a test to prevent such problems in the future when we get new traces?

Absolutely. The issue here (or not really an issue but just something to be aware of) is that the SpectralTraceList assumes that the names of the efficiency extensions are identical to those of the trace definitions. See also the docstring of SpectralEfficiency.

So actually, all IRDB packages that use traces and efficiencies should have a standardized test that simply checks if those match.

Originally posted by @teutoburg in #176 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant