Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename trace file extensions to match grating efficiency filenames #176

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

Isa29bella
Copy link
Contributor

This used to be identical in the previously default *_sci.fits trace files, and causes a silent error when attemting to include the trace efficiencies.

Created in cooperation with @teutoburg

@teutoburg teutoburg self-assigned this Apr 24, 2024
@teutoburg teutoburg added instrument-specific Limited to a certain IRDB instrument package data update New version of or change to a data file labels Apr 24, 2024
This used to be identical in the previously default *_sci.fits trace files, and causes a silent error when attemting to include the trace efficiencies.
@Isa29bella Isa29bella marked this pull request as ready for review April 24, 2024 22:12
@teutoburg teutoburg self-requested a review April 24, 2024 22:13
@teutoburg teutoburg merged commit c6344a6 into AstarVienna:dev_master Apr 24, 2024
8 checks passed
@Isa29bella Isa29bella deleted the iw/traces branch April 24, 2024 22:15
@hugobuddel
Copy link
Collaborator

For the curious reader (that is, me), this is what changed (and similar for the other bands):

fitsdiff  TRACE_LSS_L.old.fits TRACE_LSS_L.new.fits

 fitsdiff: 5.3.4
 a: TRACE_LSS_L.old.fits
 b: TRACE_LSS_L.new.fits
 Maximum number of different data values to be reported: 10
 Relative tolerance: 0.0, Absolute tolerance: 0.0

Extension HDU 1 (TOC, 1):

   Data contains differences:
     Column description data differs in row 0:
        a> 2023-06-20-spectra_Grism-L_band
        b> METIS LSS L
     1 different table data element(s) found (25.00% different).

Extension HDU 2:
   Extension names differ:
    a: 2023-06-20-spectra_Grism-L_band
    b: METIS LSS L

   Headers contain differences:
     Keyword EXTNAME  has different values:
        a> 2023-06-20-spectra_Grism-L_band
        b> METIS LSS L

@teutoburg should we add a test to prevent such problems in the future when we get new traces?

@astronomyk should we add this fix to whatever conversion script you used to convert the new traces?

@hugobuddel
Copy link
Collaborator

And thanks @Isa29bella ! Such a PR is much appreciated

@teutoburg
Copy link
Contributor

@teutoburg should we add a test to prevent such problems in the future when we get new traces?

Absolutely. The issue here (or not really an issue but just something to be aware of) is that the SpectralTraceList assumes that the names of the efficiency extensions are identical to those of the trace definitions. See also the docstring of SpectralEfficiency.

So actually, all IRDB packages that use traces and efficiencies should have a standardized test that simply checks if those match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data update New version of or change to a data file instrument-specific Limited to a certain IRDB instrument package
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants