-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix notebooks so they run again #16
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #16 +/- ##
==========================================
+ Coverage 75.82% 76.00% +0.18%
==========================================
Files 9 9
Lines 823 821 -2
==========================================
Hits 624 624
+ Misses 199 197 -2 ☔ View full report in Codecov by Sentry. |
So I don't really understand, but this breaks RTD:
I think the problem is
However, nothing changed in that respect, in fact, the notebooks were broken before. It seems that RTD only runs the notebooks when they are 'un-run' in the repository. In fact, whether RTD runs the notebooks was exactly what I wanted to verify. You added the notebooks without output, that is without running them before committing, which I think was on purpose. I do like to have the notebooks as an example about 'what to expect', and their output must be available for that. I'm fine with having the notebooks without output in the repository, as long as they have output on RTD. But that is apparently broken. I admit that having broken notebooks that do show up in the documentation is worse than having working notebooks with broken documentation, so I will approve the PR anyway. There seems to be much more broken with RTD / our documentation though: also the log of the successful build is full of Python Exceptions. So we should fix the RTD workflow to ensure the notebooks can be ran, and that exceptions raised in the rst files will trigger a failure. This probably applies to the other repositories as well. |
Hmm, I missed that e.g. |
Oh, and I'm looking at https://readthedocs.org/projects/spextra/, not spextraHB. But that doesn't seem to build the branches... |
Doesn't add them in the tests, nor really brings the information in there up to date, but at least they run now.