Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow internal updates #17

Merged
merged 3 commits into from
Jan 20, 2024
Merged

Allow internal updates #17

merged 3 commits into from
Jan 20, 2024

Conversation

teutoburg
Copy link
Contributor

This allows our own package to be updated while still in "dev mode", aka < v1.0.

Perhaps this should be rolled out to all dependency specifications for our own packages.

@teutoburg teutoburg added the dependencies Related to or updating any dependencies label Jan 19, 2024
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (88617a1) 76.00% compared to head (f3c34eb) 76.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #17   +/-   ##
=======================================
  Coverage   76.00%   76.00%           
=======================================
  Files           9        9           
  Lines         821      821           
=======================================
  Hits          624      624           
  Misses        197      197           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teutoburg teutoburg mentioned this pull request Jan 19, 2024
@teutoburg teutoburg requested a review from hugobuddel January 19, 2024 17:20
Copy link
Contributor

@hugobuddel hugobuddel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might (read: will) cause problems, because now any version of astar-utils is acceptable (if I understand correctly), but speXtra might not work with older versios.

Say someone has astar-utils 0.1.3 installed, and speXtra 0.33. We add proper logging to speXtra and release 0.40 that uses get_logger() from astar-utils 0.2.0. The user subsequently upgrades speXtra for some reason. Then pip will realize that the astar-utils dependency is already fulfilled and will keep astar-utils at 0.1.3 which does not have get_logger. Now the user has a broken installation.

This broken upgrading is something that happened frequently in the past, which led to the creation of the minimum dependencies test, to ensure that pyproject.toml does only list dependencies that actually work.

We replaced the minimum dependencies test with a minimal poetry.lock file, which also worked well. However, this poetry.lock is not in sync with pyproject.toml anymore it seems.

I propose we simply do

astar-utils = ">=0.1.3"

because it is not necessary to use the caret, since we are in full control of astar-utils anyway.

@teutoburg
Copy link
Contributor Author

Yeah, you're right. This was a silly idea. Let's just do the ">=" instead 👍

@teutoburg
Copy link
Contributor Author

However, this poetry.lock is not in sync with pyproject.toml anymore it seems.

I checked (using poetry show -T --with test --with docs) on this branch and all versions seem to match those specified as minimums in the pyproject.toml. Did I miss any?

@teutoburg teutoburg requested a review from hugobuddel January 19, 2024 21:27
@teutoburg teutoburg mentioned this pull request Jan 20, 2024
teutoburg added a commit that referenced this pull request Jan 20, 2024
This reverts commit ffeb19d.

Should instead use proper solution from #17.
@hugobuddel
Copy link
Contributor

However, this poetry.lock is not in sync with pyproject.toml anymore it seems.

I checked (using poetry show -T --with test --with docs) on this branch and all versions seem to match those specified as minimums in the pyproject.toml. Did I miss any?

I meant it was inconsistent with the ^0 it pyproject.toml. I believe you if you say it is consistent now.

Not sure about allow-prereleases. It would be fine to use allow-preleases for the dependencies of unreleased packages, or when the package itself is a pre-release, but for normal PyPI releases I think we should restrict ourselves to normal releases as dependencies. Because otherwise there would effectively be no difference between a pre-release and a normal release. I'm going to assume that is your plan.

@teutoburg teutoburg merged commit b74b277 into master Jan 20, 2024
15 checks passed
@teutoburg teutoburg deleted the fh/versions branch January 20, 2024 20:52
teutoburg added a commit that referenced this pull request Jan 21, 2024
This reverts commit ffeb19d.

Should instead use proper solution from #17.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Related to or updating any dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants