-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow internal updates #17
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #17 +/- ##
=======================================
Coverage 76.00% 76.00%
=======================================
Files 9 9
Lines 821 821
=======================================
Hits 624 624
Misses 197 197 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might (read: will) cause problems, because now any version of astar-utils
is acceptable (if I understand correctly), but speXtra might not work with older versios.
Say someone has astar-utils 0.1.3 installed, and speXtra 0.33. We add proper logging to speXtra and release 0.40 that uses get_logger()
from astar-utils 0.2.0. The user subsequently upgrades speXtra for some reason. Then pip will realize that the astar-utils dependency is already fulfilled and will keep astar-utils at 0.1.3 which does not have get_logger. Now the user has a broken installation.
This broken upgrading is something that happened frequently in the past, which led to the creation of the minimum dependencies test, to ensure that pyproject.toml does only list dependencies that actually work.
We replaced the minimum dependencies test with a minimal poetry.lock file, which also worked well. However, this poetry.lock is not in sync with pyproject.toml anymore it seems.
I propose we simply do
astar-utils = ">=0.1.3"
because it is not necessary to use the caret, since we are in full control of astar-utils anyway.
Yeah, you're right. This was a silly idea. Let's just do the ">=" instead 👍 |
I checked (using |
I meant it was inconsistent with the Not sure about |
This allows our own package to be updated while still in "dev mode", aka < v1.0.
Perhaps this should be rolled out to all dependency specifications for our own packages.