Fix waves check

[hugobuddel]

This is broken, because waves is a Quantity, and "Quantity truthiness is ambiguous, especially for logarithmic units and temperatures. Use explicit comparisons". In particular, the example in https://github.com/AstarVienna/ScopeSim_Templates/blob/main/scopesim_templates/calibration/calibration.py#L44 raises the quoted ValueError. Fixes https://github.com/AstarVienna/speXtra/pull/43/files#r1819593457

[hugobuddel]

rg -t py "(\w+) = \((\w+) or " shows no similar code like waves = (waves or ...

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.23%. Comparing base (24a62b6) to head (e4c2c09).
Report is 3 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main      #57       +/-   ##
===========================================
+ Coverage   56.78%   77.23%   +20.45%     
===========================================
  Files           8        8               
  Lines         789      795        +6     
===========================================
+ Hits          448      614      +166     
+ Misses        341      181      -160     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[teutoburg]

Thanks for fixing!

[hugobuddel]

Thanks for fixing!

Graag gedaan. I like the one-liners, but in the end I think this is also more clear. I still don't like it that we cannot just put the default in the function declaration..

One thing to note is that black_body_spectrum() claims to allow filter_curve to be None, but I couldn't get that to work properly in the tests. So I decided to do what any good developer would do, and ignored it.