Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device discovery for older Android versions #172

Merged
merged 7 commits into from
Oct 8, 2022

Conversation

jrtberlin
Copy link
Member

This should resolve #171.

@jrtberlin jrtberlin force-pushed the master branch 2 times, most recently from ca196ff to 2c0a054 Compare October 8, 2022 10:27
@eLtMosen eLtMosen self-requested a review October 8, 2022 17:35
@eLtMosen
Copy link
Member

eLtMosen commented Oct 8, 2022

Tested on stock Android 11 and found to be working flawless again.
Continuing test now on even older Android verions.
Good work @jrtberlin

@eLtMosen eLtMosen removed their request for review October 8, 2022 17:38
Copy link
Member

@eLtMosen eLtMosen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on stock Android 11 and 8 now successfully.

Copy link
Member

@MagneFire MagneFire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also tested on Android 11 and working fine with your changes applied.

One thing I'd still like to see is why these commits were made, specifically:

  • 059dfcd: A revert commit, nice. Why do the revert?
  • ac274cd: Why only request BLUETOOTH_CONNECT on Android 12+?
  • 55cde20: Change of Bluetooth name to address, why make this change? Why not show both? Due to a bug with some ports it will show the same MAC address for different watches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AsteroidOOSync v 0.23
3 participants