-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Device discovery for older Android versions #172
Conversation
ca196ff
to
2c0a054
Compare
Tested on stock Android 11 and found to be working flawless again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on stock Android 11 and 8 now successfully.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also tested on Android 11 and working fine with your changes applied.
One thing I'd still like to see is why these commits were made, specifically:
This reverts commit a8175e5. It introduced issues on some versions of Android with watch discovery.
This adds the BLUETOOTH_CONNECT permission [1] as required for Android 12+. [2] [1]: https://developer.android.com/reference/android/Manifest.permission#BLUETOOTH_CONNECT [2]: https://developer.android.com/guide/topics/connectivity/bluetooth/permissions
This should resolve #171.