Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Pytest in test_psf.py #26

Closed
bazkiaei opened this issue Sep 27, 2018 · 3 comments
Closed

Improve Pytest in test_psf.py #26

bazkiaei opened this issue Sep 27, 2018 · 3 comments
Assignees

Comments

@bazkiaei
Copy link

There are some small jobs left to improve test_psf.py and since they are small jobs, they can be handled very soon.

@lspitler
Copy link
Member

@bazkiaei good to do this soon while its still fresh. Do you need @AnthonyHorton 's input for this? Let me know if I can help.

@lspitler lspitler changed the title Improve Pytest Improve Pytest in test_psf.py Sep 27, 2018
@bazkiaei
Copy link
Author

@bazkiaei good to do this soon while its still fresh. Do you need @AnthonyHorton 's input for this? Let me know if I can help.

I am on it and I am in touch with @AnthonyHorton

bazkiaei added a commit to bazkiaei/gunagala that referenced this issue Oct 9, 2018
bazkiaei added a commit that referenced this issue Oct 9, 2018
bazkiaei added a commit that referenced this issue Oct 9, 2018
bazkiaei added a commit that referenced this issue Oct 9, 2018
bazkiaei added a commit that referenced this issue Oct 9, 2018
bazkiaei added a commit that referenced this issue Oct 9, 2018
bazkiaei added a commit to bazkiaei/gunagala that referenced this issue Nov 15, 2018
bazkiaei added a commit to bazkiaei/gunagala that referenced this issue Nov 15, 2018
bazkiaei added a commit that referenced this issue Nov 16, 2018
The `test_psf.py` parametrised and decorated.
@bazkiaei
Copy link
Author

The test_psf.py is parametrised and decorated now.
#28

lspitler pushed a commit that referenced this issue Nov 25, 2019
* Added dark frame generation to Camera, moved other astroimsim code

* Initial implementations of image simulation methods

* Docs build fix

* Remove now redundant astroimsim.py

* Memory use reduction (no longer creates huge temporary arrays)

* Fix off-by-one, array vs Quantity & floating point stopping bugs

* Fix axis 18 (#20)

* Axis order changed

* Camera.py docstring improved

* clipping below zero pixel values

* Correcting test_psf.py

* camera.py docstring improved

* below zero assert added

* below zero and infinit asserts added

* combining pairs

* `@pytest.mark.parameterize` implemented

* Some problems with ...

* something that works for now

* Crval not set as per Issue #17 (#25)

* use centre to always set CRVAL first thing

See issue: #17

* created get_pixel_coords method for Imager

* remove centre for get_pixel_coords & check for CRVAL

* add :skip: InvalidTransformError to docs/index.rst

* added test of get_pixel_coords

* fix unit=deg problems in SkyCoord

* also unit=deg fix

* another unit=deg fix

* split test and make scope function

* make_noiseless_image unit=deg

* kwargs docstrings & split star_ & centre_ kwargs

* @bazkiaei
trying to parametrize as it has been advised

* @bazkiaei
trying to parametrize as it has been advised

* Revert "Merge remote-tracking branch 'upstream/image_sim' into improve-pytest-#26"

This reverts commit 308168f.

* Revert "Merge remote-tracking branch 'upstream/image_sim' into improve-pytest-#26"

This reverts commit 4b4bc04.

* Revert "Revert "Merge remote-tracking branch 'upstream/image_sim' into improve-pytest-#26""

This reverts commit 25a4c04.

* Revert "@bazkiaei"

This reverts commit 94273a2.

* Revert "@bazkiaei"

This reverts commit c811d41.

* Revert "Merge remote-tracking branch 'upstream/image_sim' into improve-pytest-#26"

This reverts commit 308168f.

* Revert "Revert "Merge remote-tracking branch 'upstream/image_sim' into improve-pytest-#26""

This reverts commit 9eb810c.

* Improving psf_pytest.py  #26 (#28)

The `test_psf.py` parametrised and decorated.

* auto pep8

* fix pixellated call

* add notimplemented error for analytical psf

* fix real image generator bug

* rename ZWO QE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants