Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix various things based upon changes in astropy #37

Merged
merged 9 commits into from
Aug 28, 2020
Merged

fix various things based upon changes in astropy #37

merged 9 commits into from
Aug 28, 2020

Conversation

lspitler
Copy link
Member

@lspitler lspitler commented Aug 27, 2020 •
edited
Loading

Fixes a few things that have changed in astropy:

  • wcs._naxis1 is no longer used. replaced with wcs.pixel_shape
  • np.where doesn't strip astropy.units anymore
  • astropy.units unit test issue related to approx
  • small fix to array equal utility
  • fixed fixture and duplicate test function definition, probably resulting from a past Merge of ImageSim into develop

@lspitler lspitler requested a review from AnthonyHorton August 27, 2020 07:22
@lspitler lspitler marked this pull request as ready for review August 28, 2020 02:57
@lspitler lspitler requested review from danjampro and fergusL and removed request for AnthonyHorton August 28, 2020 03:04
fergusL
fergusL approved these changes Aug 28, 2020
View reviewed changes
Copy link

@fergusL fergusL left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (minus travis issues)

@lspitler lspitler merged commit 7f683b6 into develop Aug 28, 2020
@lspitler lspitler deleted the naxis_fix branch August 28, 2020 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fergusL fergusL fergusL approved these changes

@danjampro danjampro Awaiting requested review from danjampro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lspitler @fergusL