Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Laravel 8.0 support #180

Merged
merged 4 commits into from
Sep 9, 2020
Merged

Laravel 8.0 support #180

merged 4 commits into from
Sep 9, 2020

Conversation

cbl
Copy link
Contributor

@cbl cbl commented Sep 9, 2020 •
edited
Loading

This pr adds laravel 8.0 support.

  • I added the version for the required composer dependencies and added the laravel version 8.* to the run-test.yml workflow.
  • Additionally requiring legacy factories for 8.* tests.

@Gummibeer
Copy link
Member

What should I say except THANKS! 🤩🎉🚀
Outstanding work here primarily because I've already seen that the Laravel v8 upgrade wasn't this easy as others before (legacy factories).

Good job! 👍

@Gummibeer Gummibeer merged commit b43d707 into Astrotomic:master Sep 9, 2020
@Gummibeer
Copy link
Member

https://github.com/Astrotomic/laravel-translatable/releases/tag/v11.9.0

@Gummibeer Gummibeer mentioned this pull request Sep 9, 2020
Closed
@rimace
Copy link

rimace commented Sep 10, 2020

One change note is missing, this also switches to indentation from 4 spaces to one tab character.

@Gummibeer
Copy link
Member

@rimace this is already fixed in master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cbl @Gummibeer @rimace