Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make -O2 the default optimisation level on gfortran. #448

Merged
merged 1 commit into from
Feb 1, 2021

Conversation

spco
Copy link
Collaborator

@spco spco commented Feb 1, 2021

In a very small amount of testing documented at #436 (comment), this should provide a 2x speedup (and I think this is a conservative estimate in most cases, but don't have the data to back that up, just experience!)

@codecov
Copy link

codecov bot commented Feb 1, 2021

Codecov Report

Merging #448 (2b677b5) into master (48171a0) will increase coverage by 0.87%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #448      +/-   ##
==========================================
+ Coverage   64.63%   65.51%   +0.87%     
==========================================
  Files          17       17              
  Lines        2138     2047      -91     
==========================================
- Hits         1382     1341      -41     
+ Misses        756      706      -50     
Flag Coverage Δ
build 52.23% <ø> (+1.20%) ⬆️
tests 82.81% <ø> (+0.25%) ⬆️
unittests 31.61% <ø> (+0.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/argparse.f90 28.12% <0.00%> (-10.45%) ⬇️
src/constraintFunctions.f90 40.31% <0.00%> (-4.66%) ⬇️
src/atmosphereFunctions.f90 59.09% <0.00%> (-3.88%) ⬇️
src/solarFunctions.f90 90.62% <0.00%> (-3.61%) ⬇️
src/dataStructures.f90 58.06% <0.00%> (-0.21%) ⬇️
src/inputFunctions.f90 54.94% <0.00%> (-0.11%) ⬇️
test/unit_tests/solar_test.f90 100.00% <0.00%> (ø)
test/unit_tests/config_test.f90 100.00% <0.00%> (ø)
test/unit_tests/argparse_test.f90 100.00% <0.00%> (ø)
test/unit_tests/atmosphere_test.f90 100.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48171a0...2b677b5. Read the comment docs.

@spco spco merged commit 9c06d09 into master Feb 1, 2021
@spco spco deleted the optimisation_level branch February 1, 2021 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant