Initial Merge #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaishnavme
reviewed
Mar 26, 2021
There was a problem hiding this comment.
Great design. Really liked code snippet toggling feature.
For for list, input and navigation component assign code snippet is wrong.
- In Input Comp: Form Input showing code snippet of list with icons
- In List Comp: For ordered list: Showing code snippet of vertical navigation.
- In Navigation: For navigation bar: Showing code snippet of Avatar
Thats all i got. Everything else works perfect.
villdev
reviewed
Mar 27, 2021
amansethi00
reviewed
Mar 27, 2021
| </div> | ||
| <div class="alert-cont alert"> | ||
| <ion-icon name="alert-circle-sharp" class="alert-icon"></ion-icon> | ||
| <p class="alert-text">Warning</p> |
There was a problem hiding this comment.
accessibility of alert text(success,info and warning) is not optimal,I would suggest go with colors of alert from material ui
| class="avatar-img" | ||
| src="../Assests/Profile Images/woman profile 2.jpg" | ||
| /> | ||
| <ion-icon |
There was a problem hiding this comment.
ion-icon for badges should have a border,try border of 2px maybe
| Vitamin C serum for Healthy and good looking skin.. | ||
| </p> | ||
| </div> | ||
| <button class="card-btn">Add to Cart</button> |
There was a problem hiding this comment.
button do not give feedback to user,maybe add box-shadow on hover
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open for PR review
CSS component library
Deployed at: https://metaphorui.netlify.app/