-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ArrayBuffer/Blob in push messages #38
Labels
Comments
function _pushWebSocket(message) {
var msg = message instanceof ArrayBuffer || message instanceof Blob ? message : _getStringMessage(message);
var data;
//...
} |
flowersinthesand
added a commit
that referenced
this issue
Oct 11, 2013
A browser not supporting ArrayBuffer and Blob will raise the reference error
flowersinthesand
added a commit
that referenced
this issue
Oct 11, 2013
This reverts commit fd49b3f.
flowersinthesand
added a commit
that referenced
this issue
Oct 11, 2013
A browser not supporting ArrayBuffer and Blob will raise the reference error
flowersinthesand
added a commit
that referenced
this issue
Oct 11, 2013
A browser not supporting ArrayBuffer and Blob will raise the reference error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In https://github.com/Atmosphere/atmosphere-javascript/blob/master/modules/jquery/src/main/webapp/jquery/jquery.atmosphere.js#L2171
It would be possible to check if message is an ArrayBuffer or Blob and leave it as it then (they match 'object' type thus failing if dev wants to use socket.send(arraybuffer), generally used for multimedia push like videoconferencing+websocket).
The text was updated successfully, but these errors were encountered: