Fix for #709

Atmosphere · Oct 26, 2012 · 7ba7684 · 7ba7684 · buildhive · Oct 26, 2012
1 parent 85110ce
commit 7ba7684
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/modules/cpr/src/main/java/org/atmosphere/cache/AbstractBroadcasterCache.java b/modules/cpr/src/main/java/org/atmosphere/cache/AbstractBroadcasterCache.java
@@ -59,7 +59,10 @@
 
 import java.io.Serializable;
 import java.util.ArrayList;
+import java.util.Collections;
 import java.util.Iterator;
+import java.util.LinkedHashSet;
+import java.util.LinkedList;
 import java.util.List;
 import java.util.concurrent.CopyOnWriteArrayList;
 import java.util.concurrent.Executors;
@@ -76,7 +79,7 @@ public abstract class AbstractBroadcasterCache implements BroadcasterCache {
 
     private static final Logger logger = LoggerFactory.getLogger(AbstractBroadcasterCache.class);
 
-    protected final List<CachedMessage> queue = new CopyOnWriteArrayList<CachedMessage>();
+    protected final List<CachedMessage> queue = Collections.synchronizedList(new LinkedList<CachedMessage>());
 
     protected ScheduledExecutorService reaper = Executors.newSingleThreadScheduledExecutor();
 
@@ -100,7 +103,9 @@ public void run() {
 
                     if (System.currentTimeMillis() - message.currentTime() > maxCachedinMs) {
                         logger.trace("Pruning: {}", message.message());
-                        queue.remove(message);
+                        synchronized (AbstractBroadcasterCache.this) {
+                            queue.remove(message);
+                        }
                     } else {
                         break;
                     }