More fix for #170 [long-polling] Message losts during concurrent susp…

…end/broadcast
Atmosphere · Feb 2, 2012 · d0cca9c · d0cca9c
1 parent 01a1988
commit d0cca9c
Showing 1 changed file with 15 additions and 14 deletions.
diff --git a/modules/cpr/src/main/java/org/atmosphere/cpr/DefaultBroadcaster.java b/modules/cpr/src/main/java/org/atmosphere/cpr/DefaultBroadcaster.java
@@ -641,27 +641,28 @@ protected Object perRequestFilter(AtmosphereResource<?, ?> r, Entry msg) {
         Object finalMsg = msg.message;
 
         if (AtmosphereResourceImpl.class.isAssignableFrom(r.getClass())) {
-            if (AtmosphereResourceImpl.class.cast(r).isInScope()) {
-                if (r.getRequest() instanceof HttpServletRequest && bc.hasPerRequestFilters()) {
-                    Object message = msg.originalMessage;
-                    BroadcastAction a = bc.filter((HttpServletRequest) r.getRequest(), (HttpServletResponse) r.getResponse(), message);
-                    if (a.action() == BroadcastAction.ACTION.ABORT) {
-                        return null;
-                    }
-                    if (a.message() != msg.originalMessage) {
-                        finalMsg = a.message();
+            synchronized(r) {
+                if (AtmosphereResourceImpl.class.cast(r).isInScope()) {
+                    if (r.getRequest() instanceof HttpServletRequest && bc.hasPerRequestFilters()) {
+                        Object message = msg.originalMessage;
+                        BroadcastAction a = bc.filter((HttpServletRequest) r.getRequest(), (HttpServletResponse) r.getResponse(), message);
+                        if (a.action() == BroadcastAction.ACTION.ABORT) {
+                            return null;
+                        }
+                        if (a.message() != msg.originalMessage) {
+                            finalMsg = a.message();
+                        }
                     }
+                } else {
+                    // The resource is no longer valid.
+                    removeAtmosphereResource(r);
+                    BroadcasterFactory.getDefault().removeAllAtmosphereResource(r);
                 }
 
                 if (cacheStrategy == BroadcasterCache.STRATEGY.AFTER_FILTER) {
                     trackBroadcastMessage(r, finalMsg);
                 }
-            } else {
-                // The resource is no longer valid.
-                removeAtmosphereResource(r);
-                BroadcasterFactory.getDefault().removeAllAtmosphereResource(r);
             }
-
         }
         return finalMsg;
     }