Atmosphere 1.0.13 (and PrimeFaces Push) is not CDI compliant

[smithh032772]

TomEE (1.6.0 snapshot, featuring OpenWebBeans 1.2.0) says,

1. Atmosphere is not CDI compliant
2. TomEE is not Atmosphere aware
3. No link to TomEE
4. Issue may be in PrimeFaces Push (Atmosphere 1.0.13 snapshot and PrimeFaces)

I am asking TomEE committers to watch-and-or-advise on this issue. This issue is related to recently-opened-and-closed-issue 1057:

#1057

A test case is available at the following URL:

https://github.com/smithh032772/PrimePushCounter.git

This is a Netbeans 7.3 project; dependencies are as follows:

1. PrimeFaces 4.0 snapshot (2013-04-27)
2. Atmosphere 1.0.13 snapshot (2013-04-26)
3. SLF4J

To reproduce issue 1057 with this test case:

1. build WAR
2. Drop WAR in tomEE 1.6.0 snapshot (2013-04-29)
3. start TomEE
4. In browser, http://localhost:8080/PrimePushCounter
5. Press F5 or browser refresh key/button a few times, and verify log lines similar to the following in log/console:

Apr 30, 2013 4:59:15 PM org.atmosphere.cpr.DefaultBroadcaster
INFO: /counter support Out Of Order Broadcast: false
Apr 30, 2013 5:02:40 PM org.atmosphere.cpr.DefaultBroadcaster
INFO: /counter support Out Of Order Broadcast: false

[smithh032772]

Jeanfrancois, I think you mentioned, recently, that PrimeFaces Push has to be updated before Atmosphere 1.0.13 is released. TomEE thinks that the issue may be the link between PrimeFaces and Atmosphere.

this issue only occurs with 2013-04-26 version of Atmosphere 1.0.13 snapshot.

this issue does not occur with 2013-04-15 version of Atmosphere 1.0.13 snapshot

[jfarcand]

Salut...I still fail to see what is the issue :-) HAve you configured a BroadcasterLIfeCyclePolicy by any chance? That would explain...in any case, this is not an issue with Atmosphere. I don't think the log breaks your application, right?

[smithh032772]

Below is what has been in my web.xml (for PrimeFaces Push project) ever since I started using TomEE and PrimeFaces Push (Atmosphere), together. I started using them both at the same time. This configuration has been working ever since and i have not seen this new 'log' (INFO: /counter support Out Of Order Broadcast: false) on every 'full page refresh' until I started using TomEE 1.6.0 snapshot 2013-04-26 (and 4/29) and Atmosphere 1.0.13 snapshot 2013-04-26.

<servlet>
    <servlet-name>Push Servlet</servlet-name>
    <servlet-class>org.primefaces.push.PushServlet</servlet-class>
    <load-on-startup>1</load-on-startup>
    <init-param>
        <param-name>org.atmosphere.cpr.broadcasterCacheClass</param-name>
        <param-value>org.atmosphere.cache.HeaderBroadcasterCache</param-value>
    </init-param>
    <init-param>
        <param-name>org.atmosphere.cpr.broadcasterClass</param-name>
        <param-value>org.atmosphere.cpr.DefaultBroadcaster</param-value>
    </init-param>
    <init-param>
        <param-name>org.atmosphere.cpr.broadcastFilterClasses</param-name>
        <param-value>org.atmosphere.client.TrackMessageSizeFilter</param-value>
    </init-param>
    <init-param>
        <param-name>org.atmosphere.cpr.sessionSupport</param-name>
        <param-value>true</param-value>
    </init-param>
</servlet>
<servlet-mapping>
    <servlet-name>Push Servlet</servlet-name>
    <url-pattern>/primepush/*</url-pattern>
</servlet-mapping>

The log does not break my app; it just adds more lines to my log file that, IMHO, I don't want in the log file.

[smithh032772]

i hope TomEE will advise on what is necessary to make tomee 'atmosphere-aware'.

[jfarcand]

Sure, but what is the issue? The question is the application still works or you broken? If apps still works this is not an issue :-) The log is secondary here and was recently added for good.

[smithh032772]

LOL app is not broke. i'm only trying to figure out why atmosphere and tomee are not playing well together 'now'. the log just revealed that tomee (openwebbeans) and atmosphere are not playing well, now. :)

[smithh032772]

if you get a chance, please consider the test case provided.

[jfarcand]

OK so let's no make noise on the mailing list and issue :-) I'm closing this right now and will look at your sample, but since nothing is broken, ping me directly as it will direct people from the wrong direction. Thanks!

[smithh032772]

Thanks Jeanfrancois! I just downloaded 1.0.0.RC2, and this appears to be fixed in the 1.0.0.RC2 release! Thank you. I was glad to make some noise here. :)

[jfarcand]

Salut,
this is not fixed :-) The log has just been increased...you need to find why so many broadcaster are created IMO. A+

[smithh032772]

No need to do that. 1.1.0.RC2 is working fine for me and I don't see this
issue any more. If I respond further, you may consider it 'noise', and you
asked me not to make so much 'noise'. :)

On Thu, May 9, 2013 at 8:44 AM, Jeanfrancois Arcand <
[email protected]> wrote:

Salut,
this is not fixed :-) The log has just been increased...you need to find
why so many broadcaster are created IMO. A+

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/1060#issuecomment-17662326
.

[jfarcand]

I'm trying to say since the beginning of this discussion that event if you application works, it is not normal than so many broadcaster gets created. So you have a bug in your application...this is independent of the logging issue you pointed, and much more critical :-) If you set the log level to TRACE, the message you reported seeing will STILL be there. SO check your application :-)