DefaultBroadcaster.push contains recursive error

[azell]

protected void push(Entry entry) {

    if (destroyed.get()) {
        return;
    }

    String prevMessage = entry.message.toString();
    if (!delayedBroadcast.isEmpty()) {
        Iterator<Entry> i = delayedBroadcast.iterator();
        StringBuilder b = new StringBuilder();
        while (i.hasNext()) {
            Entry e = i.next();
            e.future.cancel(true);
            try {
                // Append so we do a single flush
                if (e.message instanceof String
                        && entry.message instanceof String) {
                    b.append(e.message);
                } else {
                    push(e); // Problem here!
                }
            } finally {
                i.remove();
            }
        }

        if (b.length() > 0) {
            entry.message = b.append(entry.message).toString();
        }
    }

If we pass a delayed broadcast with a message type other than String, the above code will call push() until it runs out of stack space.

[azell]

It may be easiest to split push into two methods.

[jfarcand]

Wow great finding. Looking at it. Who wrote that code :-)

[jfarcand]

Integrated