Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility check for 'org.apache.catalina.websocket.WebSocketServlet' with jbossweb 7.2.2.Final yields a false positive #1262

Closed
bleathem opened this issue Aug 30, 2013 · 1 comment
Closed

Compatibility check for 'org.apache.catalina.websocket.WebSocketServlet' with jbossweb 7.2.2.Final yields a false positive #1262

bleathem opened this issue Aug 30, 2013 · 1 comment
Labels
1.0.17

Comments

@bleathem
Copy link
Contributor

The 7.2.2.Final release of jbossweb now includes the class org.apache.catalina.websocket.WebSocketServlet. This is the class used to test for the presence of Tomcat 7 websockets on the class path. This check leads to a false positive, and later blows up with a ClassNotFoundException for the org.apache.coyote.http11.upgrade.UpgradeInbound class.

A reasonable resolution for this issue would appear to be to replace the check for the WebSocketServlet class with one for UpgradeInbound in the check for support of Tomcat 7 Websockets.

Note: This issue was initially reported in the RichFaces issue: RF-13154, but will likely affect any application that uses Atmosphere with jbossweb 7.2.2.Final
@bleathem
Copy link
Contributor Author

I tried the proposed patch and can confirm it resolves the problem with jbossweb 7.2.2.Final. I'll submit a pull request.

bleathem added a commit to bleathem/atmosphere that referenced this issue Aug 30, 2013
@bleathem
Fixes Atmosphere#1262 - changes the check class for Tomcat 7 Websocke…
b13b143 
…t support.

The check for the WebSocketServlet class is replaced with a check for the UpgradeInbound class in the check for support of Tomcat 7 Websockets.
jfarcand added a commit that referenced this issue Sep 2, 2013
@jfarcand
Merge pull request #1263 from bleathem/atmosphere-1.0.x
e06af44 
Fixes #1262 - changes the check class for Tomcat 7 Websocket support.
@jfarcand jfarcand closed this as completed Sep 2, 2013
jfarcand pushed a commit that referenced this issue Sep 3, 2013
@bleathem @jfarcand
Fixes #1262 - changes the check class for Tomcat 7 Websocket support.
25377a3 
The check for the WebSocketServlet class is replaced with a check for the UpgradeInbound class in the check for support of Tomcat 7 Websockets.
@vaadin-bot vaadin-bot mentioned this issue Dec 10, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.0.17
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jfarcand @bleathem