-
-
Notifications
You must be signed in to change notification settings - Fork 756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finer priority management for interceptors #1574
Comments
@jfarcand I just draft a possible refactoring for invocation order. The idea is to make possible to specify the order of invocation between two interceptors that are configured to be executed after default or before default interceptors. This draft also gives the possibility to simplify AtmosphereFramework class:
This approach also introduces new rules:
Take a look at the code and tell me if I'm going in the wrong way. Will continue if you're agree with this. |
Well, by using meta services provided in #1573, I can order additional interceptors as required. I won't work on it while it is YAGNI. Even if it could be a good internal enhancement, it doesn't bring additional value for the user for now. There is a big challenge to not break anything, we should work on it only if we really need it! |
Currently we can configure Atmosphere to execute two interceptors before/after the defaults but we can't change the order between them.
The text was updated successfully, but these errors were encountered: