Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[atmosphere.js] Firefox Bug: getAllResponseHeaders() returns empty String #273

Closed
haed opened this issue Apr 10, 2012 · 4 comments
Closed

Comments

@haed
Copy link
Contributor

haed commented Apr 10, 2012

Bug report: https://bugzilla.mozilla.org/show_bug.cgi?id=608735

Here is a workaround/patch (which we use), but it's just a quick hotfix (insert these lines in atmosphere.js#783):

if (_request.headers) {
  jQuery.each(_request.headers, function(name) {
    var v = ajaxRequest.getResponseHeader(name);
    if (v) {
      _response.headers[name] = v;
    }
  });
}

This reads explicitly all headers set in request.headers (takes the names).

@jfarcand
Copy link
Member

Integrated, thanks!

@kirach
Copy link

kirach commented Apr 16, 2012

But your integrated fix is located inside block

if (jQuery.browser.opera) {
    ...
}

Seems, it will never invoked in firefox, isn't it?

@jfarcand
Copy link
Member

Hum...not sure how I've missed it. Re-opening the issue.

@jfarcand jfarcand reopened this Apr 16, 2012
jfarcand added a commit that referenced this issue Apr 17, 2012
@jfarcand
Copy link
Member

Properly fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants