-
-
Notifications
You must be signed in to change notification settings - Fork 756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AtmosphereRequest.getSession returns null when session is set #311
Labels
Comments
euh looking |
Like this return session != null && isNotNoOps() ? b.request.getSession(false) : session; ? |
jfarcand
added a commit
that referenced
this issue
Apr 27, 2012
Ya the above is the solution IMO. Integrated. Do you need a 0.9.2 release for it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The 'fix' for #284 causes AtmosphereRequest.getSession(false) to always return null when 'session' is not null. IMHO the else part of the inline if should be 'session', not 'null'. This change breaks Wicket-atmosphere completely because wicket looses its session.
The text was updated successfully, but these errors were encountered: