Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AtmosphereRequest.getSession returns null when session is set #311

Closed
papegaaij opened this issue Apr 27, 2012 · 3 comments
Closed

AtmosphereRequest.getSession returns null when session is set #311

papegaaij opened this issue Apr 27, 2012 · 3 comments

Comments

@papegaaij
Copy link

The 'fix' for #284 causes AtmosphereRequest.getSession(false) to always return null when 'session' is not null. IMHO the else part of the inline if should be 'session', not 'null'. This change breaks Wicket-atmosphere completely because wicket looses its session.

@jfarcand
Copy link
Member

euh looking

@jfarcand
Copy link
Member

Like this

        return session != null && isNotNoOps() ? b.request.getSession(false) : session;

?

@jfarcand
Copy link
Member

Ya the above is the solution IMO. Integrated. Do you need a 0.9.2 release for it?

jfarcand added a commit that referenced this issue Apr 27, 2012
jfarcand added a commit that referenced this issue May 30, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants