Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong error/warning message on TrackMessageSizeFilter #896

Closed
laeubi opened this issue Feb 10, 2013 · 0 comments
Closed

Wrong error/warning message on TrackMessageSizeFilter #896

laeubi opened this issue Feb 10, 2013 · 0 comments
Labels

Comments

@laeubi
Copy link

laeubi commented Feb 10, 2013

in AtmosphereFramework there is this code:

        for (String i: broadcasterFilters) {
            if (i.equals(TrackMessageSizeFilter.class.getName())) {
                found = true;
                break;
            }
        }
        if (!found) {
            logger.warn("Neither TrackMessageSizeInterceptor or TrackMessageSizeFilter are installed." +
                    " atmosphere.js may receive glued and incomplete message.");
        }

If you configure your own filter like:
org.atmosphere.cpr.broadcastFilterClasses=org.apache.wicket.atmosphere.TrackMessageSizeFilter
then the error/warning is issued even if there is one filter, because the Stringcomparision obviously not work here...

jfarcand added a commit that referenced this issue Feb 10, 2013
jfarcand added a commit that referenced this issue Feb 12, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants