encodeURL and encodeRedirectURL return null

[papegaaij]

AtmosphereResponse uses a Proxy that always returns null for some methods, like encodeURL and encodeRedirectURL. This causes major problems in rendering Wicket components (https://issues.apache.org/jira/browse/WICKET-5084). These two methods are essential for Wicket to work and I think Atmosphere should implement them correctly.

[jfarcand]

OK sound a like a regression since 1.0.10 right? Was it working before? It happens with WebSocket only, right?

[papegaaij]

Yes. I can confirm it worked correctly in 1.0.9 and it does not occur when using streaming.

[jfarcand]

OK, will re-add the following (which was doing nothing BTW. I will evaluate how I can implement it properly for websocket. When do you need an official release?

[papegaaij]

I can work around it quite easily in Wicket (using the same dummy implementation) for now, so no need to rush on your part.

[martin-g]

Reverting only encodeURL(String url) and encodeRedirectURL(String url) should be enough.

[jfarcand]

Working on it, will release 1.0.13 soon with the fix.

[jfarcand]

OK fixed. I've added a new factory called ServletProxyFactory that can be used to customize all the Proxy in Atmosphere. You can do it by doing:

  ServletProxyFactory.getDefault().addMethodName(String, MethodHandler);