Fix for race condition #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in very close succession
|
Great that you were able to fix this! Good job! Since the patch is in Atmosphere core I will leave it to JF to review and pull. Thanks, |
|
Thanks!!!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for race condition if two messages are broadcast to the same resource in very close succession. I can reproduce this issue synthetically by making two calls (one right after the other) to AtmosphereGwtHandler.doServerMessage(). The first message ends up getting overwritten by the second message before it is sent to the gwt client and the gwt client ends up receiving the second message twice. Let me know if you have any other preference for the fix and I can re-submit. Btw, thanks for this project.