Fix race condition in DefaultBroadcasterFactory in Atmosphere 0.8.x #100
+144
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix race condition in DefaultBroadcasterFactory
| @@ -92,7 +92,7 @@ | |||
| * | |||
| * @param b a {@link Broadcaster} | |||
| * @return false if wasn't present, or {@link Broadcaster} | |||
| * @oaram id the {@link Broadcaster's ID} | |||
| * @param id the {@link Broadcaster's ID} | |||
There was a problem hiding this comment.
Fixed javadoc markup issue.
|
Many thanks. I've added the default license header, feel free to change it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Race condition when performing a lookup and creating if null. The synchronized statement in get(Class<? extends Broadcaster> c, Object id) is insufficient to ensure that two threads don't create a broadcaster with the same ID. Two strings that are equal, but are different objects may enter the block at the same time. To fix, make the get() method call the lookup method, and change the lookup method to better use the ConcurrentHashMap methods to guarantee that only one broadcaster can be returned with a particular ID.
Fixed remove() to use ConcurrentHashMap method to guarantee atomicity.