#1580 - default-web-module support #1583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…turns false if the request doesn't start with the servlet contextpath. However, if the webapp is set as the default-web-module, then the request will not start with the contextpath since GlassFish strips that from the request. To fix, we just need to ensure that the contextpath is removed from the start of the request path, instead of requiring it to be so.
jfarcand
added a commit
that referenced
this pull request
May 5, 2014
#1580 - default-web-module support
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GlassFishWebSocketHandler.isApplicationRequest() returns false if the request doesn't start with the servlet contextpath. However, if the webapp is set as the default-web-module, then the request will not start with the contextpath since GlassFish strips that from the request.
To fix, we just need to ensure that the contextpath is removed from the start of the request path, instead of requiring it to be so.