Added better message reasons during websocket.onclose where a String reason isn't provided #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The final changed line modifies the condition for choosing to either retry websocket or downgrade. The previous code would display "Websocket closed cleanly" even when the close was defined as not being clean. It may be that the correct behaviour is to accept the previous condition and just change the log message! |
jfarcand
added a commit
that referenced
this pull request
Oct 11, 2011
Added better message reasons during websocket.onclose where a String reason isn't provided
jfarcand
added a commit
that referenced
this pull request
May 30, 2012
Added better message reasons during websocket.onclose where a String reason isn't provided
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edited modules/jquery/src/main/webapp/jquery/jquery.atmosphere.js via GitHub