Fix for #707 webSocketUrl Jersey dispatching #714
Merged
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ability to get AtmosphereRequest's internal _request field, namely to allow redefining webSocketUrl after subscribing. This allows you to subscribe to a resource with no webSocketUrl, then redefine webSocketUrl before a push to control which resource method the message is POSTed through when using WebSocket. Further work will involve redefining webSocketUrl to a more generic actionUrl or similar field, and extending the other transports to also respect this URL extension.
|
Atmosphere Framework » atmosphere #372 SUCCESS |
jfarcand
added a commit
that referenced
this pull request
Oct 26, 2012
Fix for #707 webSocketUrl Jersey dispatching
|
Atmosphere Framework » atmosphere #373 UNSTABLE |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #707 webSocketUrl does not dispatch to proper Jersey resource method