Set the contentLength on the AtmosphereRequest. #35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi JeanFrancois
the
contentLength
is not correctly reported from theAtmosphereRequest
ascreateAtmosphereRequest
in theNettyAtmosphereHandler
has no means of setting it (it is always 0, stemming fromNoOpsRequest
, I think). There is noHttpServletRequest
object it could set on theBuilder.request
field. I would thus suggest to :contentLength
field in theBuilder
(see my complementing pull request in Atmosphere) , with a defensive extension to thegetContentLength()
method ofAtmosphereRequest
.createAtmosphereRequest
to retrieve the contentLength from the headers and set the newly introducedBuilder
field forcontentLength
.This is only a proposal, maybe there is a more elegant way to have the
AtmosphereRequest
reflect the proper content length.Cheers, Christian.