-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed multitype list #1076
base: master
Are you sure you want to change the base?
Fixed multitype list #1076
Conversation
thankyou |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AryazE Sorry. Can you modify all the scripts to use floats?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I think some changes should be rollbacked. PTAL. @AryazE
@@ -210,33 +210,33 @@ def main(): | |||
print(__file__ + " start!!") | |||
|
|||
# start and goal position | |||
sx = 10.0 # [m] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, we can keep these float parameters as before.
for i in range(0, 40): | ||
ox.append(40.0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, we can keep these float parameters as before.
sy = -5.0 # [m] | ||
gx = 50.0 # [m] | ||
gy = 50.0 # [m] | ||
grid_size = 2.0 # [m] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, we can keep these float parameters as before.
for i in range(40): | ||
ox.append(40.0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, we can keep these float parameters as before.
sy = 10.0 # [m] | ||
gx = 50.0 # [m] | ||
gy = 50.0 # [m] | ||
robot_size = 5.0 # [m] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, we can keep these float parameters as before.
for i in range(40): | ||
ox.append(40.0) | ||
oy.append(60.0 - i) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, we can keep these float parameters as before.
sy = 10.0 # [m] | ||
gx = 50.0 # [m] | ||
gy = 50.0 # [m] | ||
robot_size = 5.0 # [m] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, we can keep these float parameters as before.
Reference issue
What does this implement/fix?
This PR ensures that the lists provided to some path planning algorithms are all
int
s and not a mix offloat
andint
.Additional information
CheckList