Add Repeat version of Tileable2D function that accepts custom repeat interval. #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Of course, I made a typo, so I need to make a tweak. 🤔 Good quality PR here, folks. |
Auburn
requested changes
Oct 11, 2021
| int xSize, int ySize, float frequency, int seed ) const = 0; | ||
| int xSize, int ySize, float frequency, int seed ) const = 0; | ||
|
|
||
| virtual FastNoise::OutputMinMax GenTileable2DRepeat(float* noiseOut, |
| virtual FastNoise::OutputMinMax GenTileable2DRepeat(float* noiseOut, | ||
| int xStart, int yStart, | ||
| int xSize, int ySize, | ||
| float xRepeat, float yRepeat, |
There was a problem hiding this comment.
x/yRepeat should be ints and rename to x/yPeriod
| @@ -114,7 +114,13 @@ namespace FastNoise | |||
| float frequency, int seed ) const = 0; | |||
|
|
|||
| virtual OutputMinMax GenTileable2D( float* out, | |||
There was a problem hiding this comment.
Make this call GenTileable2DRange to avoid code duplication
| @@ -1189,6 +1189,12 @@ FastNoise::OutputMinMax FastNoiseNodeEditor::GenerateNodePreviewNoise( FastNoise | |||
| Node::NoiseSize, Node::NoiseSize, | |||
| mNodeFrequency, mNodeSeed ); | |||
|
|
|||
| case NoiseTexture::GenType_2DTiledRepeat: | |||
There was a problem hiding this comment.
I would leave out the NoiseTool preview option, it doesn't have much purpose and is not configurable anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I mostly wanted to use this myself for personal projects, but decided to throw it in a PR.
I've added the function
GenTileable2DRepeatto theGeneratorclass. It serves the same purpose asGenTileable2D, but with a few extra parameters.xStart/yStart, determining the offset in the same manner asGenUniformGrid2D,and
xRepeat/yRepeat, which determine how long large the Tileable area is.This allows users to make a large repeating noise period, and sample only parts of it, rather than
GenTileable2D's behavior, which only tiles as large as the dataset it's generating for.I've made sure this compiles and runs at least on Windows, I've added it to the C file, and I've added an option for it in the texture view mode.