Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove string concatenation in SQL statements #8

Open
tessereth opened this issue Feb 2, 2017 · 2 comments
Open

Remove string concatenation in SQL statements #8

tessereth opened this issue Feb 2, 2017 · 2 comments
Assignees

Comments

@tessereth
Copy link
Contributor

There probably aren't any SQL injections here. But we should fix it anyway.

@tessereth
Copy link
Contributor Author

This may not be possible. Most (if not all) of the places that have string concatination won't actually work with placeholder arguments. This card should possibly change to "Make sure all arguments added to an sql query are checked against a good regex first".

@aeijdenberg
Copy link
Contributor

While placeholder arguments won't work in all cases, there are often alternatives for identifiers, such as https://godoc.org/github.com/lib/pq#QuoteIdentifier for Postgres. Assigning to self to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants