fix(core): enhancement AnomalyDetector and LoadRetriever #1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
* Enhancement AnomalyDetector always execute * Enhancement LoadRetriever always execute
Wzy19930507
changed the title
SCNieh
reviewed
Mar 27, 2024
| @@ -428,8 +428,8 @@ public void retrieve() { | |||
| createTopic(); | |||
| this.mainExecutorService.schedule(this::retrieve, 1, TimeUnit.SECONDS); | |||
| return; | |||
| } catch (Exception e) { | |||
| logger.error("Consumer poll error", e); | |||
| } catch (Throwable throwable) { | |||
There was a problem hiding this comment.
We rerun the task on Exception is because Exception is expected to be recoverable, however for non-recoverable cases (like most of the Error), schedule another task is unneccessary becasue the current JVM status is unpredictable, so maybe just add catch Throwable after Exception, and logging it properly
| } catch (Exception e) { | ||
| logger.error("Consumer poll error", e); | ||
| } catch (Throwable throwable) { | ||
| logger.error("Consumer poll throwable", throwable); |
There was a problem hiding this comment.
there is no need to change the logging text here, as "throwable" is an adj.
SCNieh
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #989