test(e2e): version upgrade test #1822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llzcx
requested review from
superhx,
SCNieh,
ShadowySpirits and
Chillax-0v0
as code owners
superhx
reviewed
Aug 20, 2024
| 'partitions': self.partitions, | ||
| 'replication-factor': self.replication_factor, | ||
| 'configs': { | ||
| 'min.insync.replicas': 2 |
tests/kafkatest/version.py
Outdated
| @@ -127,6 +127,8 @@ def get_version(node=None): | |||
| # This should match the LATEST_PRODUCTION version defined in MetadataVersion.java | |||
| LATEST_STABLE_METADATA_VERSION = "3.7" | |||
|
|
|||
| LATEST_STABLE_FEATURE_VERSION = '3' | |||
There was a problem hiding this comment.
change the name to LATEST_STABLE_AUTOMQ_VERSION
| ['s3.wal.cache.size', str(log_size)], | ||
| ['s3.wal.capacity', str(log_size)], | ||
| ['s3.wal.upload.threshold', str(log_size // 4)], | ||
| ['s3.block.cache.size', str(block_size)], |
There was a problem hiding this comment.
Why should we change the configs
superhx
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.