perf(s3stream/wal): reuse the ByteBuf for record headers
#1877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ning Yu <[email protected]>
Signed-off-by: Ning Yu <[email protected]>
Signed-off-by: Ning Yu <[email protected]>
Signed-off-by: Ning Yu <[email protected]>
Chillax-0v0
requested review from
superhx,
SCNieh and
ShadowySpirits
as code owners
superhx
previously approved these changes
Aug 20, 2024
This reverts commit ed63112.
Signed-off-by: Ning Yu <[email protected]>
ShadowySpirits
approved these changes
Aug 20, 2024
Chillax-0v0
added a commit
that referenced
this pull request
Aug 20, 2024
* refactor: manage the record headers' lifecycle in `Block` Signed-off-by: Ning Yu <[email protected]> * perf(s3stream/wal): reuse the `ByteBuf` for record headers Signed-off-by: Ning Yu <[email protected]> * perf: remove the max size limit Signed-off-by: Ning Yu <[email protected]> * test: test `FixedSizeByteBufPool` Signed-off-by: Ning Yu <[email protected]> * revert: "perf: remove the max size limit" This reverts commit ed63112. * feat: use a separate `poolSize` to limit the size of the pool Signed-off-by: Ning Yu <[email protected]> --------- Signed-off-by: Ning Yu <[email protected]>
Chillax-0v0
added a commit
that referenced
this pull request
Aug 21, 2024
…1878) * perf(s3stream/wal): reuse the `ByteBuf` for record headers (#1877) * refactor: manage the record headers' lifecycle in `Block` Signed-off-by: Ning Yu <[email protected]> * perf(s3stream/wal): reuse the `ByteBuf` for record headers Signed-off-by: Ning Yu <[email protected]> * perf: remove the max size limit Signed-off-by: Ning Yu <[email protected]> * test: test `FixedSizeByteBufPool` Signed-off-by: Ning Yu <[email protected]> * revert: "perf: remove the max size limit" This reverts commit ed63112. * feat: use a separate `poolSize` to limit the size of the pool Signed-off-by: Ning Yu <[email protected]> --------- Signed-off-by: Ning Yu <[email protected]> * perf: increase the size of the buffer pool as CPU cores Signed-off-by: Ning Yu <[email protected]> --------- Signed-off-by: Ning Yu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1874