perf(s3stream): optimize the critical section in s3 wal #1880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SSpirits <[email protected]>
ShadowySpirits
requested review from
superhx,
SCNieh and
Chillax-0v0
as code owners
Signed-off-by: SSpirits <[email protected]>
Chillax-0v0
reviewed
Aug 21, 2024
s3stream/src/main/java/com/automq/stream/FixedSizeByteBufPool.java
Outdated
Show resolved
Hide resolved
s3stream/src/main/java/com/automq/stream/s3/wal/impl/object/ObjectWALService.java
Outdated
Show resolved
Hide resolved
Chillax-0v0
reviewed
Aug 21, 2024
s3stream/src/main/java/com/automq/stream/s3/wal/impl/object/ObjectWALService.java
Outdated
Show resolved
Hide resolved
Signed-off-by: SSpirits <[email protected]>
Chillax-0v0
previously approved these changes
Aug 22, 2024
Signed-off-by: SSpirits <[email protected]>
Chillax-0v0
approved these changes
Aug 22, 2024
ShadowySpirits
added a commit
that referenced
this pull request
Aug 22, 2024
* perf(s3stream): optimize the critical section in s3 wal Signed-off-by: SSpirits <[email protected]> * fix(s3stream): fix check style Signed-off-by: SSpirits <[email protected]> * feat(s3stream): optimize Signed-off-by: SSpirits <[email protected]> * fix(s3stream): fix resource leak in test Signed-off-by: SSpirits <[email protected]> --------- Signed-off-by: SSpirits <[email protected]> (cherry picked from commit 3bbaf81)
ShadowySpirits
added a commit
that referenced
this pull request
Aug 22, 2024
* perf(s3stream): optimize the critical section in s3 wal Signed-off-by: SSpirits <[email protected]> * fix(s3stream): fix check style Signed-off-by: SSpirits <[email protected]> * feat(s3stream): optimize Signed-off-by: SSpirits <[email protected]> * fix(s3stream): fix resource leak in test Signed-off-by: SSpirits <[email protected]> --------- Signed-off-by: SSpirits <[email protected]> (cherry picked from commit 3bbaf81)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1874