feat(stream-client): perf and optimize #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
superhx
commented
Sep 7, 2023
superhx
commented
- Change buffer to direct.
- Add S3Storage cache limit protection.
- Add object data block flag(support compressed in future).
- change buffer to direct - add S3Storage cache limit protection - add object data block flag(support compressed in future) Signed-off-by: Robin Han <[email protected]>
Signed-off-by: Robin Han <[email protected]>
Signed-off-by: Robin Han <[email protected]>
TheR1sing3un
reviewed
Sep 7, 2023
TheR1sing3un
reviewed
Sep 7, 2023
| @@ -255,13 +269,25 @@ public CompletableFuture<Void> close() { | |||
| if (closeCf != null) { | |||
| return closeCf; | |||
| } | |||
| System.out.println("start await close: " + (System.nanoTime() - start) / 1000 / 1000); | |||
There was a problem hiding this comment.
why system print? how about print it to log?
TheR1sing3un
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.