Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add random_state to experiment runner #2

Merged
merged 3 commits into from
Dec 1, 2023

Conversation

hollandjg
Copy link
Member

@hollandjg hollandjg commented Dec 1, 2023

Description

Add a random_state argument to the experiment runner.
Update documentation and doctests – show examples of pandas data frames first (because the numpy arrays are less clear)

Type of change

Delete as appropriate:

  • feat: A new feature

@hollandjg hollandjg self-assigned this Dec 1, 2023
@hollandjg hollandjg added bug Something isn't working priority 0: emergency These can be blockers, or security issues, and should be resolved immediately. labels Dec 1, 2023
@hollandjg hollandjg requested a review from musslick December 1, 2023 21:32
@hollandjg hollandjg marked this pull request as ready for review December 1, 2023 21:32
@hollandjg hollandjg enabled auto-merge December 1, 2023 21:48
Copy link
Contributor

@younesStrittmatter younesStrittmatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@hollandjg hollandjg merged commit 6c0f0b0 into main Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority 0: emergency These can be blockers, or security issues, and should be resolved immediately.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants