feat: model inventory #250
Conversation
…ound truth and domain
|
bump. @musslick @chadcwilliams @gtdang |
|
hi @musslick , @benwandrew , @chadcwilliams and @gtdang – here's the updated model inventory PR for your perusal. |
|
This is very well done! It is all very intuitive and I could follow along all of the files without a hitch. I had no issues, so you definitely have my thumbs up. |
|
|
||
| from autora.variable import VariableCollection | ||
|
|
||
|
|
||
| @runtime_checkable |
There was a problem hiding this comment.
What does this decorator do?
There was a problem hiding this comment.
That means that you can do an isinstance(x, _SyntheticExperimentClosure) call and check whether x fulfills the Protocol.
| @singledispatch | ||
| def describe(arg): | ||
| """ | ||
| Print the docstring for a synthetic experiment. | ||
|
|
||
| Args: | ||
| arg: the experiment's ID, an object returned from the `retrieve` function, or a closure | ||
| which creates a new experiment. | ||
| """ | ||
| raise NotImplementedError(f"{arg=} not yet supported") | ||
|
|
||
|
|
||
| @describe.register | ||
| def _(closure: _SyntheticExperimentClosure): | ||
| print(closure.__doc__) | ||
|
|
||
|
|
||
| @describe.register | ||
| def _(collection: SyntheticExperimentCollection): | ||
| describe(collection.closure) | ||
|
|
||
|
|
||
| @describe.register | ||
| def _(id_: str): | ||
| describe(retrieve(id_)) |
There was a problem hiding this comment.
Very cool! Didn't know about this! Is my understanding correct that if the object type is not one of the of the registered types it will default to the base (first) function?
There was a problem hiding this comment.
Yes! That's it. It's just a different way of doing
if isinstance(x, SyntheticExperimentCollection):
... do something ...
elif isinstance(x, str):
... do something else ...
else:
... throw an errorwhich neatly leverages the type hints.
Description
Add the model inventory.
part of #232
resolves #232
Type of change:
Features:
Questions: