Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: make github action only install main and test dependencies #306

Merged
merged 3 commits into from
Mar 24, 2023

Conversation

hollandjg
Copy link
Member

Alternative fix strategy for poetry problems

gtdang and others added 2 commits March 21, 2023 11:47
…tion to false.

This correct an issue with and invalid debugpy wheel with Poetry v1.4.1 modern installer.
@hollandjg hollandjg changed the base branch from main to fix/poetry_installer March 22, 2023 23:04
@hollandjg hollandjg changed the base branch from fix/poetry_installer to main March 22, 2023 23:05
@hollandjg hollandjg requested a review from gtdang March 24, 2023 14:35
@hollandjg hollandjg marked this pull request as ready for review March 24, 2023 14:35
@hollandjg hollandjg requested a review from musslick as a code owner March 24, 2023 14:35
@hollandjg hollandjg enabled auto-merge March 24, 2023 14:37
Copy link
Collaborator

@gtdang gtdang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed with John. Determined this is the better solution than #300 for now. Will keep an eye on poetry issue and releases to see if they create a different solution.

python-poetry/poetry#7686

@hollandjg hollandjg added this pull request to the merge queue Mar 24, 2023
Merged via the queue into main with commit 12f2c39 Mar 24, 2023
@hollandjg hollandjg deleted the fix/poetry_installer-alternate branch March 24, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants